Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jans-fido2): jansPublicKeyId updated to 256 characters #7121

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

Milton-Ch
Copy link
Contributor

@Milton-Ch Milton-Ch commented Dec 17, 2023

Prepare


Description

  • jansPublicKeyId field size update to 256 characters
  • Updating the fido config-build.properties file

closes #7114


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@mo-auto mo-auto added comp-jans-fido2 Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Dec 17, 2023
Signed-off-by: Milton Ch <j.milton.chambi.m@gmail.com>
Copy link

sonarcloud bot commented Dec 17, 2023

Quality Gate Passed Quality Gate passed for 'Fido2 API'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Milton-Ch Milton-Ch marked this pull request as ready for review December 17, 2023 01:36
@yurem yurem enabled auto-merge (squash) December 18, 2023 19:09
@yurem yurem merged commit 33728da into main Dec 18, 2023
1 of 2 checks passed
@yurem yurem deleted the fix/public-key-id-size branch December 18, 2023 19:09
Copy link

sonarcloud bot commented Dec 18, 2023

Quality Gate Passed Quality Gate passed for 'orm'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Dec 18, 2023

Quality Gate Passed Quality Gate passed for 'jans-config-api-parent'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Dec 18, 2023

Quality Gate Passed Quality Gate passed for 'keycloak-integration-parent'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

devrimyatar pushed a commit that referenced this pull request Dec 30, 2023
…#7121)

Signed-off-by: Milton Ch <j.milton.chambi.m@gmail.com>
Signed-off-by: Mustafa Baser <mbaser@mail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-fido2 Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(jans-casa): error when registering a fido device at jans-casa
4 participants